test: Unquarantine K8sDatapathConfig Encapsulation #22674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole group of encapsulation-related tests was quarantined in cilium#18051. But there was never any reason to quarantine the whole group as only a couple of tests are actually failing. According to DataStudio [1], nowadays only the iptables-masquerading tests are failing. So this commit reenables all tests in that group except for the two iptables-masquerading tests. Note that this group includes our only coverage of IPsec + VXLAN. 1 - https://datastudio.google.com/s/nBvri2iDdrc Signed-off-by: Paul Chaignon <paul@cilium.io>
|
/test |
tklauser
approved these changes
Dec 12, 2022
|
Although those are datapath tests, I believe it's okay to skip the datapath review because the changes are straightforward and the rationale/consequence is based on DataStudio data. All Required tests passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole group of encapsulation-related tests was quarantined in #18051. But there was never any reason to quarantine the whole group as only a couple of tests are actually failing.
According to DataStudio, nowadays only the iptables-masquerading tests are failing. So this commit reenables all tests in that group except for the two iptables-masquerading tests.
Note that this group includes our only coverage of IPsec + VXLAN.