test, jenkinsfile: Clean up natnetworks in CI after test run #22704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI-improvement
pchaigno
force-pushed
the
ci-clean-natnetworks
branch
from
3356049
to
d5c17f2
Compare
tklauser
reviewed
Dec 14, 2022
pchaigno
force-pushed
the
ci-clean-natnetworks
branch
2 times, most recently
from
be81cae
to
2a7b157
Compare
We currently have a flake in CI that is caused by some incorrect VirtualBox natnetwork configuration. It is currently unclear why the natnetworks are sometimes created with an incorrect configuration. Unfortunately, because we don't delete natnetworks at the end of each CI job, those incorrect natnetworks remains for subsequent runs and the tests end up failing with the same flake on every single CI job executed on that node. This commit adds a cleanup step for natnetworks in our CI. We still won't run natnetworks when running tests locally, for the same reason we don't clean up VMs. This change doesn't fix the flake but it should limit its impact to a single CI job instead of all jobs running on a node. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
ci-clean-natnetworks
branch
from
2a7b157
to
1942b98
Compare
|
/test-vagrant |
tklauser
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a flake in CI that is caused by some incorrect VirtualBox natnetwork configuration. It is currently unclear why the natnetworks are sometimes created with an incorrect configuration.
Unfortunately, because we don't delete natnetworks at the end of each CI job, those incorrect natnetworks remains for subsequent runs and the tests end up failing with the same flake on every single CI job executed on that node.
This pull request adds a cleanup step for natnetworks in our CI. We still won't run natnetworks when running tests locally, for the same reason we don't clean up VMs. This change doesn't fix the flake but it should limit its impact to a single CI job instead of all jobs running on a node.
Related: #17353 (comment).