Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update KPR limitations wrt IPsec #22775

Merged
merged 1 commit into from Jan 3, 2023
Merged

docs: Update KPR limitations wrt IPsec #22775

merged 1 commit into from Jan 3, 2023

Conversation

raymonddejong
Copy link
Contributor

KPR is supported with Wireguard, but not with IPSec. This update of the docs reflects that.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Update of the KPR limitations page as KPR is supported with Wireguard but not with IPSec.

<!-- Enter the release note text here if needed or remove this section! -->

@maintainer-s-little-helper
Copy link

Commit d681166be6af1457c18246a3cf225e586a28ed78 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 16, 2022
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Dec 16, 2022
brb
brb reviewed Dec 16, 2022
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I will ACK once you sign off the commit.

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Dec 16, 2022
@raymonddejong raymonddejong marked this pull request as ready for review December 16, 2022 14:40
@raymonddejong raymonddejong requested review from a team as code owners December 16, 2022 14:40
@maintainer-s-little-helper

This comment was marked as resolved.

Sign in to view
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Dec 16, 2022
@maintainer-s-little-helper

This comment was marked as resolved.

Sign in to view
pchaigno
pchaigno requested changes Dec 16, 2022
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Documentation/network/kubernetes/kubeproxy-free.rst Outdated Show resolved Hide resolved
Documentation/network/kubernetes/kubeproxy-free.rst Show resolved Hide resolved
@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Dec 16, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 16, 2022
@pchaigno pchaigno added area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 16, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 16, 2022
@raymonddejong raymonddejong changed the title docs-update-limitations docs: Update KPR limitations wrt IPsec Dec 16, 2022
@raymonddejong
docs: Update KPR limitations with regards to IPSec
3060b58 
KPR is supported with Wireguard, but not with IPSec. This update of the docs should reflect that.

Signed-off-by: Raymond de Jong <raymond.dejong@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Dec 19, 2022
@raymonddejong raymonddejong requested review from pchaigno and brb and removed request for pchaigno December 19, 2022 12:53
@brb brb mentioned this pull request Jan 3, 2023
Closed
@brb brb requested a review from pchaigno January 3, 2023 10:59
@maintainer-s-little-helper

This comment was marked as resolved.

Sign in to view
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jan 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jan 3, 2023
@pchaigno
Copy link
Member

pchaigno commented Jan 3, 2023

The Documentation workflow passed. There are no changes to the docs structure. Merging.

@pchaigno pchaigno merged commit c7d08f6 into cilium:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@pchaigno pchaigno pchaigno approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raymonddejong @pchaigno @brb