Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Clarify committer vote procedures #22787

Merged
merged 2 commits into from Jan 18, 2023
Merged

docs: Clarify committer vote procedures #22787

merged 2 commits into from Jan 18, 2023

Conversation

joestringer
Copy link
Member

A couple of questions have come up recently around how to handle
communication for voting processes for committer access. Improve the
docs to make these steps more clear for subsquent nominations and votes.

@joestringer joestringer requested review from a team as code owners December 19, 2022 02:05
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Dec 19, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 19, 2022
@joestringer joestringer marked this pull request as draft December 22, 2022 00:58
@joestringer joestringer marked this pull request as ready for review January 12, 2023 23:37
@qmonnet qmonnet added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Jan 13, 2023
qmonnet
qmonnet approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@qmonnet qmonnet removed the request for review from aditighag January 13, 2023 15:27
qmonnet
qmonnet requested changes Jan 13, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spellchecker complains on reposted. Should be ready to merge after this is addressed.

@joestringer
docs: Clarify committer vote procedures
630f24c 
A couple of questions have come up recently around how to handle
communication for voting processes for committer access. Improve the
docs to make these steps more clear for subsquent nominations and votes.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer
docs: Convert committer admittance to imperative
19f982a 
Change the way this is expressed into an enumerated list so that it's
clearer which order things must be done. Add also the step to admit the
committer to the committer group in GitHub, which was previously implied
but not pointed out.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer merged commit 9a58f44 into cilium:master Jan 18, 2023
@joestringer joestringer deleted the submit/vote-docs branch January 18, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizrice lizrice lizrice approved these changes

@sayboras sayboras sayboras approved these changes

@qmonnet qmonnet Awaiting requested review from qmonnet

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joestringer @lizrice @sayboras @qmonnet