Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Document the hooks that Cilium uses #22792

Merged
merged 1 commit into from Feb 15, 2023
Merged

docs: Document the hooks that Cilium uses #22792

merged 1 commit into from Feb 15, 2023

Conversation

joestringer
Copy link
Member

No description provided.

@joestringer joestringer requested a review from a team as a code owner December 19, 2022 04:59
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Dec 19, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 19, 2022
@joestringer joestringer requested review from a team and dylandreimerink and removed request for a team December 19, 2022 05:00
@joestringer joestringer marked this pull request as draft December 22, 2022 00:56
@joestringer joestringer marked this pull request as ready for review January 12, 2023 22:58
ldelossa
ldelossa approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome addition.

@qmonnet qmonnet added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Jan 13, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Feb 15, 2023
@qmonnet
Copy link
Member

qmonnet commented Feb 15, 2023

This PR is probably still of interest, I'm removing the stale label for this time.

@qmonnet qmonnet removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Feb 15, 2023
@joestringer
Copy link
Member Author

Given #23555 , I'm going to drop the documentation around sockops.

@joestringer
docs: Document the hooks that Cilium uses
192dea5 
Technically we also have the following, but their use is deprecated so I
have omitted them from this commit:
- ``BPF_PROG_TYPE_SOCK_OPS``
- ``BPF_PROG_TYPE_SK_MSG``

Signed-off-by: Joe Stringer <joe@cilium.io>
qmonnet
qmonnet approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@joestringer joestringer merged commit a422990 into cilium:master Feb 15, 2023
@joestringer joestringer deleted the submit/hooks-docs branch February 15, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandreimerink dylandreimerink dylandreimerink left review comments

@aditighag aditighag aditighag left review comments

@ldelossa ldelossa ldelossa approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joestringer @qmonnet @dylandreimerink @ldelossa @aditighag