Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Clean up RBAC artifacts for v1.13 CI #22823

Merged
merged 1 commit into from Dec 22, 2022

Conversation

joestringer
Copy link
Member

This commit is the v1.13 CI equivalent of git commit 43cb8e9
(".github: manually clean up RBAC artifacts"), necessary until we
resolve cilium/cilium-cli#1257 .

Related: #22822

This commit is the v1.13 CI equivalent of git commit 43cb8e9
(".github: manually clean up RBAC artifacts"), necessary until we
resolve cilium/cilium-cli#1257 .

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer requested review from a team as code owners December 21, 2022 04:06
@joestringer joestringer added the release-note/ci This PR makes changes to the CI. label Dec 21, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 21, 2022
@joestringer
Copy link
Member Author

For the record, I only noticed that there was a workflow conflict while backporting #22656 and assumed that a change like this is necessary to ensure the v1.13 backport passes CI, but I haven't observed any strict need for it just yet. Probably @squeed will have a better idea how this fits together.

@joestringer joestringer merged commit 11a7e88 into master Dec 22, 2022
@joestringer joestringer deleted the pr/joe/per-node-cleanup-1.13 branch December 22, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cilium uninstall doesn't clean up all RBAC objects (breaks reinstall)
2 participants