operator: Fix use of Resource.Events() in CEC controller #22844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit "resource: Refactor the API for simplified usage" was tested against older master, before the commit "cli: Add configuration flag for service LB" which used the older API, causing the build to fail. This updates StartCECController() to use the new Resource.Events method. Fixes: f3a9b0a ("resource: Refactor the API for simplified usage") Signed-off-by: Jussi Maki <jussi@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
joamaki
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
dylandreimerink
approved these changes
Dec 22, 2022
|
Relevant tests pass showing that the build is fixed (conformance, image builds, go lint), merging. |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit "resource: Refactor the API for simplified usage" was tested against older master, before the commit "cli: Add configuration flag for service LB" which used the older API, causing the build to fail.
This updates StartCECController() to use the new Resource.Events method.
Fixes: f3a9b0a ("resource: Refactor the API for simplified usage")