Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/endpoint: Use structured logging for error condition #22846

Merged
merged 1 commit into from Jan 4, 2023
Merged

pkg/endpoint: Use structured logging for error condition #22846

merged 1 commit into from Jan 4, 2023

Conversation

christarazi
Copy link
Member

Found via code inspection.

Signed-off-by: Chris Tarazi chris@isovalent.com

@christarazi christarazi added area/daemon Impacts operation of the Cilium daemon. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Dec 22, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 22, 2022
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Dec 22, 2022
@christarazi christarazi removed the kind/community-contribution This was a contribution made by a community member. label Dec 22, 2022
@christarazi christarazi marked this pull request as ready for review December 22, 2022 19:52
@christarazi christarazi requested a review from a team as a code owner December 22, 2022 19:52
@christarazi christarazi marked this pull request as draft December 23, 2022 01:16
@christarazi
pkg/endpoint: Use structured logging for error condition
cc65ddc 
Found via code inspection.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
christarazi commented Dec 23, 2022
View reviewed changes
pkg/endpoint/events.go Outdated Show resolved Hide resolved
@christarazi christarazi marked this pull request as ready for review December 23, 2022 02:08
@christarazi
Copy link
Member Author

christarazi commented Dec 27, 2022 •
edited

/test

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks N/S loadbalancing Tests with XDP, direct routing, Hybrid and Random

Failure Output

FAIL: Can not connect to service "tftp://[fd04::11]:31438/hello" from outside cluster (3/10)

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Edit: #22579

@christarazi christarazi mentioned this pull request Jan 4, 2023
Closed
@christarazi
Copy link
Member Author

Marking ready to merge as we have approving reviews and CI passing except for known flakes.

@christarazi christarazi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 4, 2023
@pchaigno pchaigno merged commit 051fd77 into cilium:master Jan 4, 2023
@christarazi christarazi deleted the pr/christarazi/ep-err-log-fmt branch January 4, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

Assignees
No one assigned
Labels
area/daemon Impacts operation of the Cilium daemon. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christarazi @tommyp1ckles @pchaigno