Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gha: Replace deprecated set-output commands #22890

Merged
merged 1 commit into from Jan 11, 2023
Merged

gha: Replace deprecated set-output commands #22890

merged 1 commit into from Jan 11, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Dec 29, 2022 •
edited

The changes are done by below command, thanks to @tklauser in cilium/cilium-cli#1296

sed -i \
  "/::set-output/ {
    s/::set-output name=/'/;
    s/::/=/;
    s/$/' >> \$GITHUB_OUTPUT/;
  }" \
.github/workflows/*.yaml

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@maintainer-s-little-helper
Copy link

Commit d4e105a09054a927af33a407b09935a3323d2abf does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 29, 2022
@maintainer-s-little-helper
Copy link

Commit d4e105a09054a927af33a407b09935a3323d2abf does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Dec 29, 2022
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Dec 29, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 29, 2022
@sayboras sayboras added area/CI Continuous Integration testing issue or flake dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 29, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 29, 2022
@maintainer-s-little-helper
Copy link

Commit 8d7422bcde35e246fd616e6f58f25b36a1c8568c does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Dec 29, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Dec 29, 2022
@sayboras
gha: Replace deprecated set-output commands
782a75f 
The changes are done by below command, thanks to @tklauser in
cilium/cilium-cli#1296

```bash
sed -i \
  '/::set-output/ {
    s/::set-output name=//;
    s/::/=/;
    s/$/ >> $GITHUB_OUTPUT/;
  }' \
.github/workflows/*.yaml
```

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
Copy link
Member Author

sayboras commented Dec 29, 2022 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.16-kernel-4.9' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) with L7 policy Tests NodePort with L7 Policy

Failure Output

FAIL: Request from k8s1 to service http://10.110.115.144:10080 failed

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.16-kernel-4.9 so I can create one.

@sayboras sayboras marked this pull request as ready for review December 29, 2022 10:31
@sayboras sayboras requested review from a team as code owners December 29, 2022 10:31
@sayboras
Copy link
Member Author

All GHA jobs are passed, kindly note that not all changes are tested in this PR as some GHA jobs are for older branches (e.g. backport PR). However, the similar changes are already verified in master branch.

Failure on test-1.16-4.9 is not related to this PR.

@sayboras sayboras mentioned this pull request Jan 10, 2023
Closed
pchaigno
pchaigno approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sayboras
Copy link
Member Author

Reviews from required teams are in, marking this ready to merge.

@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 10, 2023
@aditighag
Copy link
Member

aditighag commented Jan 11, 2023 •
edited

All GHA jobs are passed, kindly note that not all changes are tested in this PR as some GHA jobs are for older branches (e.g. backport PR). However, the similar changes are already verified in master branch.

Failure on test-1.16-4.9 is not related to this PR.

@sayboras Can you link to an existing flake issue, or if it it doesn't exist, create a new one? Thanks!

Edit: The artifacts are not available anymore.

@aditighag aditighag merged commit c55943f into cilium:master Jan 11, 2023
@sayboras sayboras deleted the tam/set-output-gha branch January 11, 2023 19:53
@sayboras sayboras mentioned this pull request Jan 26, 2023
Merged
@sayboras sayboras mentioned this pull request Jan 26, 2023
Merged
michi-covalent pushed a commit to michi-covalent/cilium that referenced this pull request Jul 7, 2023
@sayboras @qmonnet
gha: Replace deprecated set-output commands
e7aba05 
The changes are done by below command, thanks to @tklauser in
cilium/cilium-cli#1296

```bash
sed -i \
  '/::set-output/ {
    s/::set-output name=//;
    s/::/=/;
    s/$/ >> $GITHUB_OUTPUT/;
  }' \
.github/workflows/*.yaml
```

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Relates: cilium#22890
Signed-off-by: Tam Mach <tam.mach@cilium.io>
mhofstetter pushed a commit to mhofstetter/cilium that referenced this pull request Jul 19, 2023
@sayboras @aanm
gha: Replace deprecated set-output commands
b3d06d3 
The changes are done by below command, thanks to @tklauser in
cilium/cilium-cli#1296

```bash
sed -i \
  '/::set-output/ {
    s/::set-output name=//;
    s/::/=/;
    s/$/ >> $GITHUB_OUTPUT/;
  }' \
.github/workflows/*.yaml
```

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Relates: cilium#22890
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@pchaigno pchaigno pchaigno approved these changes

@joestringer joestringer Awaiting requested review from joestringer joestringer was automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sayboras @aditighag @nebril @pchaigno