Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Correct PRELOAD_VM environment variable #22902

Merged
merged 1 commit into from Jan 4, 2023
Merged

docs: Correct PRELOAD_VM environment variable #22902

merged 1 commit into from Jan 4, 2023

Conversation

Shunpoco
Copy link
Contributor

@Shunpoco Shunpoco commented Jan 2, 2023

Document says VM_PRELOAD is the environment variable which controls VM preloading for Local CI VM. However, the actual environment variable is PRELOAD_VM (Please see here).

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!
docs: modify `PRELOAD_VM` for local CI VM

@Shunpoco
Fix document: PRELOAD_VM is a correct environment variable
9aaa216 
Document says `VM_PRELOAD` is the environment variable which controls
VM preloading for Local CI VM. However, the actual environment variable
is `PRELOAD_VM`.

Signed-off-by: Shunsuke Tokunaga <tkngsnsk313320@gmail.com>
@Shunpoco Shunpoco requested review from a team as code owners January 2, 2023 03:21
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 2, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 2, 2023
@sayboras sayboras changed the title Fix document: PRELOAD_VM is a correct environment variable docs: Correct PRELOAD_VM environment variable Jan 3, 2023
@sayboras sayboras added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jan 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 3, 2023
sayboras
sayboras approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@pchaigno
Copy link
Member

pchaigno commented Jan 4, 2023

No changes to the docs structure so we can skip that review and the Documentation CI job is passing. Merging.

@pchaigno pchaigno merged commit 72e9eaa into cilium:master Jan 4, 2023
@pchaigno
Copy link
Member

pchaigno commented Jan 4, 2023

Thanks for the fix!

@Shunpoco Shunpoco deleted the fix-docs-ci-vm-local-preload branch January 5, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@sayboras sayboras sayboras approved these changes

@nebril nebril Awaiting requested review from nebril nebril was automatically assigned from cilium/contributing

@joestringer joestringer Awaiting requested review from joestringer joestringer was automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shunpoco @pchaigno @sayboras