Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:'go routine' should be 'goroutine' #22904

Merged
merged 1 commit into from Jan 7, 2023
Merged

fix:'go routine' should be 'goroutine' #22904

merged 1 commit into from Jan 7, 2023

Conversation

yulng
Copy link
Contributor

@yulng yulng commented Jan 2, 2023

Signed-off-by: yulng wei.yang@daocloud.io

Usually, goroutine is represented by goroutine

Thanks

@yulng yulng requested review from a team as code owners January 2, 2023 10:13
@yulng yulng requested a review from brb January 2, 2023 10:13
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 2, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 2, 2023
mainred
mainred reviewed Jan 3, 2023
View reviewed changes
Copy link

@mainred mainred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thank you.

There'll be more search results than you find in this current PR, will you fix them as well? like

cilium/daemon/cmd/daemon.go

Line 737 in 17ad4e1

log.Info("Waiting for all endpoints' go routines to be stopped.")

Please also ignore case when searching.

@yulng
fix:'go routine' should be 'goroutine'
fe5c272 
Signed-off-by: yulng <wei.yang@daocloud.io>
@yulng
Copy link
Contributor Author

yulng commented Jan 3, 2023

Good catch and thank you.

There'll be more search results than you find in this current PR, will you fix them as well? like

cilium/daemon/cmd/daemon.go

Line 737 in 17ad4e1

log.Info("Waiting for all endpoints' go routines to be stopped.")

Please also ignore case when searching.

changed all
thanks

kaworu
kaworu approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@kaworu kaworu added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Jan 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 3, 2023
@aditighag
Copy link
Member

Only fixing logs and comments, so no need to run the full CI.

@aditighag aditighag merged commit 80af06e into cilium:master Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@mainred mainred mainred approved these changes

@christarazi christarazi christarazi approved these changes

@aditighag aditighag aditighag approved these changes

@brb brb Awaiting requested review from brb brb was automatically assigned from cilium/wireguard

@nebril nebril Awaiting requested review from nebril nebril was automatically assigned from cilium/sig-policy

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yulng @aditighag @kaworu @mainred @christarazi