Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local CI VM: Add comments for NFS's IP ranges #22934

Merged
merged 1 commit into from Jan 27, 2023
Merged

Local CI VM: Add comments for NFS's IP ranges #22934

merged 1 commit into from Jan 27, 2023

Conversation

Shunpoco
Copy link
Contributor

@Shunpoco Shunpoco commented Jan 5, 2023

Like contrib/vagrant/start.sh, we should add comments about NFS's ip ranges on scripts for Local CI VMs.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #22901

test: add comments for NFS's IP ranges on local CI VM scripts

@Shunpoco
Local CI VM: Add comments for NFS's ip ranges
59283cb 
Like contrib/vagrant/start.sh, we should add comments about NFS's ip
ranges on scripts for Local CI VMs.

Fixes: cilium#22901

Signed-off-by: Shunsuke Tokunaga <tkngsnsk313320@gmail.com>
@Shunpoco Shunpoco requested a review from a team as a code owner January 5, 2023 04:08
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 5, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 5, 2023
Shunpoco
Shunpoco commented Jan 5, 2023
View reviewed changes
test/vagrant-local-start.sh
@@ -20,6 +20,12 @@ else
unset SERVER_VERSION
fi

if [[ "$NFS" != "0" ]]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ip range are from here

@christarazi christarazi added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 5, 2023
@christarazi
Copy link
Member

/test

@aanm aanm merged commit 607d870 into cilium:master Jan 27, 2023
@Shunpoco Shunpoco deleted the local-ci-vm-add-iptables-comment branch January 28, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@ldelossa ldelossa ldelossa approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow kind/community-contribution This was a contribution made by a community member. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot mount a NFS when running a CI VM instance locally
4 participants
@Shunpoco @christarazi @ldelossa @aanm