Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc:fix networking.k8s.io/v1beta1 for ingress #22968

Merged
merged 1 commit into from Jan 10, 2023
Merged

Doc:fix networking.k8s.io/v1beta1 for ingress #22968

merged 1 commit into from Jan 10, 2023

Conversation

yulng
Copy link
Contributor

@yulng yulng commented Jan 7, 2023 •
edited

Signed-off-by: yulng wei.yang@daocloud.io

Update document Ingress to networking.k8s.io/v1beta1
According to the following document:
https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

image

docs: Update output for "cilium status" when troubleshooting (extensions/v1beta1::Ingress now deprecated in favor of networking.k8s.io/v1beta1::Ingress)

@yulng yulng requested a review from a team as a code owner January 7, 2023 12:53
@yulng yulng requested a review from qmonnet January 7, 2023 12:53
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 7, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 7, 2023
qmonnet
qmonnet approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just the output of a command so looks good to me, we don't really have to worry about K8s version in there.

Not a blocker, but it would be nice if you could add a bit more context to your commit description, though (e.g. why the change, what version of Kubernetes introduced the new API versioning).

Thanks!

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jan 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 9, 2023
@maintainer-s-little-helper
Copy link

Commit 7efaef0e5de5153b0ebe8c0e984262b0cc048d3c does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jan 10, 2023
@yulng
fix:networking.k8s.io/v1beta1 for ingress
ec5ed62 
"Ingress in the extensions/v1beta1 API version will no longer be served
Migrate to use the networking.k8s.io/v1beta1 API version, available since v1.14. Existing persisted data can be retrieved/updated via the new version."
https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

Signed-off-by: yulng <wei.yang@daocloud.io>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jan 10, 2023
@yulng
Copy link
Contributor Author

yulng commented Jan 10, 2023 •
edited

This is just the output of a command so looks good to me, we don't really have to worry about K8s version in there.

Not a blocker, but it would be nice if you could add a bit more context to your commit description, though (e.g. why the change, what version of Kubernetes introduced the new API versioning).

Thanks!

ok,updated the commit with version description
thanks

qmonnet
qmonnet approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 10, 2023
@aditighag aditighag merged commit f920eb4 into cilium:master Jan 10, 2023
@joestringer joestringer mentioned this pull request Jan 19, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yulng @qmonnet @aditighag