Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make log statements easier to read #22971

Merged
merged 1 commit into from Jan 25, 2023
Merged

Make log statements easier to read #22971

merged 1 commit into from Jan 25, 2023

Conversation

yulng
Copy link
Contributor

@yulng yulng commented Jan 8, 2023

Printing the entire structure of the identity in the log makes the log hard to read ,so branch printing

Signed-off-by: yulng wei.yang@daocloud.io

@yulng yulng requested review from a team as code owners January 8, 2023 11:33
@yulng yulng requested a review from aditighag January 8, 2023 11:33
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 8, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 8, 2023
@kaworu kaworu added kind/enhancement This would improve or streamline existing functionality. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Jan 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 9, 2023
kaworu
kaworu reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yulng and thanks for the PR

Printing the entire structure of the identity in the log makes the log hard to read ,so branch printing

As far as I can see the patch is cosmetic only and introduce no functional change. If correct then I don't understand the commit message, what is "branch printing"?

@yulng
Copy link
Contributor Author

yulng commented Jan 10, 2023

It is printed line by line, unified style, easy to view
thanks

christarazi
christarazi requested changes Jan 19, 2023
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this change is purely cosmetic, can you reword the commit to

Make log statements easier to read

This is a cosmetic change to break up long log lines into smaller lines.

@christarazi christarazi added kind/cleanup This includes no functional changes. and removed kind/enhancement This would improve or streamline existing functionality. labels Jan 19, 2023
@christarazi christarazi marked this pull request as draft January 19, 2023 16:55
@christarazi christarazi changed the title Optimization logs with entire identity object Make log lines easier to read Jan 19, 2023
@christarazi christarazi changed the title Make log lines easier to read Make log statements easier to read Jan 19, 2023
@yulng
Copy link
Contributor Author

yulng commented Jan 20, 2023

Since this change is purely cosmetic, can you reword the commit to

Make log statements easier to read

This is a cosmetic change to break up long log lines into smaller lines.

Push again and update the commit
Thanks

@yulng @christarazi
Make log statements easier to read
b86e74f 
This is a cosmetic change to break up long log lines into smaller lines

Signed-off-by: yulng <wei.yang@daocloud.io>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi marked this pull request as ready for review January 23, 2023 21:33
@christarazi
Copy link
Member

/test

@kaworu
Copy link
Member

kaworu commented Jan 24, 2023 •
edited

/test-runtime
EDIT: runtime did hit #22750, re-running.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 24, 2023
@ldelossa ldelossa merged commit ce152da into cilium:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/cleanup This includes no functional changes. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yulng @christarazi @kaworu @ldelossa