Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update hostfw tuto with ICMP policy rule #22999

Merged
merged 1 commit into from Jan 10, 2023
Merged

docs: Update hostfw tuto with ICMP policy rule #22999

merged 1 commit into from Jan 10, 2023

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Jan 9, 2023

This pull request updates the host firewall getting started guide to also allow ICMP echo requests as part of the initial policy.

Suggested-by: Rob Landers landers.robert@gmail.com
Signed-off-by: Paul Chaignon paul@cilium.io

@pchaigno
docs: Update hostfw tuto with ICMP policy rule
f6203f4 
This commit updates the host firewall getting started guide to also
allow ICMP echo requests as part of the initial policy.

Suggested-by: Rob Landers <landers.robert@gmail.com>
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. release-note/misc This PR makes changes that have no direct user impact. area/host-firewall Impacts the host firewall or the host endpoint. labels Jan 9, 2023
@pchaigno pchaigno requested a review from a team as a code owner January 9, 2023 23:17
@pchaigno pchaigno requested a review from qmonnet January 9, 2023 23:17
@pchaigno pchaigno mentioned this pull request Jan 9, 2023
Closed
qmonnet
qmonnet approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, thanks. Travis error is unrelated, good to merge.

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 10, 2023
@aditighag aditighag merged commit a0e201b into cilium:master Jan 10, 2023
@pchaigno pchaigno deleted the docs-hostfw-icmp branch January 10, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/host-firewall Impacts the host firewall or the host endpoint. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pchaigno @qmonnet @aditighag