hive: Add hive.Command() #23074
Merged
hive: Add hive.Command() #23074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joamaki
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
|
/test |
joamaki
force-pushed
the
pr/joamaki/hive-commands
branch
from
a07b53e
to
06e2d08
Compare
tklauser
reviewed
Jan 12, 2023
joamaki
force-pushed
the
pr/joamaki/hive-commands
branch
5 times, most recently
from
f90f738
to
fcd4641
Compare
Remove endpoint-gc-interval flag from option.Config as it already was in endpointmanager.Config. Looks like use of PersistentFlags() allowed duplicates. PersistentFlags no longer needed as the hive sub-command now takes the hive's flag set (so it doesn't need to inherit from root command). Signed-off-by: Jussi Maki <jussi@isovalent.com>
Implement the commands for hive object and dot-graph dumping centrally, so we'll avoid duplicate implementations in each binary. Add the hive as sub-command to agent, operator and clustermesh-apiserver. Add a test for the agent cell to check that it can be instantiated with the default configuration so we don't break the ability to inspect the agent hive. Remove endpoint-gc-interval flag from option.Config as it already was in endpointmanager.Config. Looks like use of PersistentFlags() allowed duplicates. PersistentFlags no longer needed as the hive sub-command now takes the hive's flag set (so it doesn't need to inherit from root command). Signed-off-by: Jussi Maki <jussi@isovalent.com>
LBIPAM nil-deref'd when k8s configuration was not provided, fix by adding a nil check. While at it, move lbipam cell definitions to cell.go. Add test to operator to check that the operator hive can be populated. Signed-off-by: Jussi Maki <jussi@isovalent.com>
The line wrapping was still broken when there were multiple wrapped lines, since after wrapping the current line length was miscalculated. Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
force-pushed
the
pr/joamaki/hive-commands
branch
from
fcd4641
to
4b12b49
Compare
|
/test Job 'Cilium-PR-K8s-1.16-kernel-4.9' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
tklauser
approved these changes
Jan 26, 2023
tklauser
removed
the
kind/community-contribution
joamaki
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hive.Command() now implements the hive related cobra commands, so they don't need to be repeated per binary. See commits for more details.