Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/ip package remove Redundant type conversion #23108

Merged
merged 1 commit into from Feb 1, 2023
Merged

pkg/ip package remove Redundant type conversion #23108

merged 1 commit into from Feb 1, 2023

Conversation

tanberBro
Copy link
Contributor

@tanberBro tanberBro commented Jan 16, 2023 •
edited by qmonnet 

pkg/ip: Remove redundant type conversions

pkg/ip package remove Redundant type conversion
e77b84b 
Signed-off-by: tanberBro <pengfei.song@daocloud.io>
@tanberBro tanberBro requested a review from a team as a code owner January 16, 2023 11:05
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 16, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 16, 2023
@tanberBro
Copy link
Contributor Author

tanberBro commented Jan 16, 2023 •
edited

@squeed

@ti-mo ti-mo added the release-note/misc This PR makes changes that have no direct user impact. label Jan 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 20, 2023
ti-mo
ti-mo approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ti-mo
Copy link
Contributor

ti-mo commented Jan 20, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 1, 2023
@qmonnet qmonnet merged commit 7960a9e into cilium:master Feb 1, 2023
@qmonnet qmonnet added the kind/cleanup This includes no functional changes. label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-mo ti-mo ti-mo approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tanberBro @ti-mo @qmonnet