bpf: Consistent usage of MARK_MAGIC_ constants
#23125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
sig/datapath
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
pchaigno
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
We currently use 8 bits of the packet mark to indicate that SNAT was already performed. That is more than necessary and inconsistent with other users of the packet mark for similar purposes. This commit changes that to only use 4 bits under the reserved MARK_MAGIC_HOST_MASK mask. Also worth noting that the IPsec comment here is incorrect: MARK_MAGIC_KEY_ID is currently unused so it wasn't conflicting with the SNAT mark. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
consistent-magic-mark-usage
branch
from
a47ac3a
to
23d5ee7
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use 8 bits of the packet mark to indicate that SNAT was already performed. That is more than necessary and inconsistent with other users of the packet mark for similar purposes.
This pull request changes that to only use 4 bits under the reserved
MARK_MAGIC_HOST_MASKmask.Also worth noting that the IPsec comment here is incorrect:
MARK_MAGIC_KEY_IDis currently unused so it wasn't conflicting with the SNAT mark.