Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alibabacloud: Support selecting subnet by IDs #23131

Merged
merged 1 commit into from Feb 1, 2023
Merged

alibabacloud: Support selecting subnet by IDs #23131

merged 1 commit into from Feb 1, 2023

Conversation

jaffcheng
Copy link
Contributor

The vswitches field in Alibabacloud Spec is defined in Cilium CNI network configuration but not implemented.
This patch implements selecting vSwitch(subnet) by specified IDs.

Signed-off-by: Jaff Cheng jaff.cheng.sh@gmail.com

alibabacloud: Support selecting subnet by IDs

@jaffcheng
alibabacloud: Support selecting subnet by IDs
864b744 
The `vswitches` field in Alibabacloud Spec is defined in Cilium CNI network
configuration but not implemented.
This patch implements selecting vSwitch(subnet) by specified IDs.

Signed-off-by: Jaff Cheng <jaff.cheng.sh@gmail.com>
@jaffcheng jaffcheng requested a review from a team as a code owner January 17, 2023 10:07
@jaffcheng jaffcheng requested a review from aanm January 17, 2023 10:07
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 17, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 17, 2023
@aanm aanm closed this Jan 18, 2023
@aanm aanm reopened this Jan 18, 2023
@jaffcheng
Copy link
Contributor Author

@christarazi Hi, sorry for disturbing you, could you take a look at this when you have time?
I don't have access to the team member page https://github.com/orgs/cilium/teams/alibabacloud but I guess you are in this team.

@aanm aanm closed this Jan 29, 2023
@aanm aanm reopened this Jan 29, 2023
@aanm aanm added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jan 29, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 29, 2023
@aanm
Copy link
Member

aanm commented Jan 29, 2023

/test-runtime

@aanm aanm self-assigned this Jan 29, 2023
@christarazi christarazi added sig/ipam IP address management, including cloud IPAM area/alibaba Impacts Alibaba based IPAM. kind/enhancement This would improve or streamline existing functionality. labels Jan 30, 2023
@aanm
Copy link
Member

aanm commented Feb 1, 2023

Smoke tests + runtime should be enough to test this PR. Merging...

@aanm aanm merged commit c53bec0 into cilium:master Feb 1, 2023
@jaffcheng jaffcheng deleted the ali-select-subnet-by-specified-ids-upstream branch February 2, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

Assignees

@aanm aanm

Labels
area/alibaba Impacts Alibaba based IPAM. kind/community-contribution This was a contribution made by a community member. kind/enhancement This would improve or streamline existing functionality. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/ipam IP address management, including cloud IPAM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaffcheng @aanm @christarazi