clustermesh/types: don't panic on invalid IP in PrefixClusterFromCIDR #23137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ip.MustAddrFromIP will panic in case of an invalid address. These types of conversion functions should usually only be used in test code. Return an empty PrefixCluster in this case instead, like in other error cases. Fixes: b4e75da ("clustermesh: Add some helper functions to PrefixCluster") Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
area/clustermesh
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
aanm
removed
the
needs-backport/1.13
|
Dropped needs-backport/1.13 label since the PR that introduced the original changes is not part of the 1.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ip.MustAddrFromIP will panic in case of an invalid address. These types of conversion functions should usually only be used in test code. Return an empty PrefixCluster in this case instead, like in other error cases.
Fixes: b4e75da ("clustermesh: Add some helper functions to PrefixCluster")