Use workflow configuration variables for quay organization names #23145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've defined QUAY_ORGANIZATION and QUAY_ORGANIZATION_DEV workflow configuration variables, so we don't need to use the composite action to set these as environment variables anymore. Ref: https://github.blog/changelog/2023-01-10-github-actions-support-for-configuration-variables-in-workflows/ Suggested-by: Nicolas Busseneau <nicolas@isovalent.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
github-actions
bot
added
the
kind/community-contribution
michi-covalent
added
the
needs-backport/1.13
tklauser
approved these changes
Jan 18, 2023
aanm
approved these changes
Jan 18, 2023
|
@bimmlerd Do we need to backport this for 1.12? |
|
yeah I think we want this for all stable branches, actually. |
aanm
removed
needs-backport/1.11
needs-backport/1.13
|
removed needs-backport labels since this PR was reverted in #23169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've defined QUAY_ORGANIZATION and QUAY_ORGANIZATION_DEV workflow configuration variables, so we don't need to use the composite action to set these as environment variables anymore.
Ref: https://github.blog/changelog/2023-01-10-github-actions-support-for-configuration-variables-in-workflows/
Suggested-by: Nicolas Busseneau nicolas@isovalent.com
Signed-off-by: Michi Mutsuzaki michi@isovalent.com