Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use workflow configuration variables for quay organization na… #23169

Merged
merged 1 commit into from Jan 18, 2023
Merged

Revert "Use workflow configuration variables for quay organization na… #23169

merged 1 commit into from Jan 18, 2023

Conversation

michi-covalent
Copy link
Contributor

…mes"

This reverts commit f28b8e2.

Workflow configuration variables are not available for pull requests from forks.

Signed-off-by: Michi Mutsuzaki michi@isovalent.com

@michi-covalent
Revert "Use workflow configuration variables for quay organization na…
476edb2 
…mes"

This reverts commit f28b8e2.

Workflow configuration variables are not available for pull requests
from forks.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent requested review from a team as code owners January 18, 2023 17:19
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 18, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 18, 2023
aditighag
aditighag approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞 Thanks for the fast turnaround!

tklauser
tklauser approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😿

@michi-covalent michi-covalent added the release-note/ci This PR makes changes to the CI. label Jan 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 18, 2023
@michi-covalent
Copy link
Contributor Author

tests are expected to fail in this PR because the composite action will not exist in the master branch until this PR gets merged 😑

@michi-covalent michi-covalent added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 18, 2023
@ldelossa ldelossa merged commit 53bcbe8 into master Jan 18, 2023
@ldelossa ldelossa deleted the pr/michi/revert-struggle branch January 18, 2023 17:25
@YutaroHayakawa YutaroHayakawa mentioned this pull request Jan 19, 2023
Merged
@aanm aanm mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

@aditighag aditighag aditighag approved these changes

@aanm aanm Awaiting requested review from aanm aanm was automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@michi-covalent @tklauser @nbusseneau @aditighag @ldelossa