k8s/watchers: Fix race condition in init functions #23170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christarazi
added
sig/k8s
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
christarazi
added
kind/bug
|
/test |
|
/test-4.19-race |
|
/test-4.9-race |
|
Race pipeline tests failed because they found another very similar race condition, pushing a new fix for it too. |
christarazi
force-pushed
the
pr/christarazi/fix-k8s-race-cond
branch
from
156a53e
to
7b61112
Compare
|
/test |
|
/test-4.19-race |
|
/test-4.9-race |
christarazi
changed the title
|
Found another instance of the same race condition issue, pushing new fix. |
christarazi
force-pushed
the
pr/christarazi/fix-k8s-race-cond
branch
from
7b61112
to
10306fd
Compare
Use an atomic variable as the previous boolean was being passed around to different goroutines without any synchronization mechanism. Fixes: b4335ee ("k8s: Introduce shared resources") Fixes: ee2ccda ("k8s: Add shared resource for namespaces") Fixes: cilium#23166 Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/fix-k8s-race-cond
branch
from
10306fd
to
c66cec7
Compare
|
/test |
|
/test-4.9-race |
|
/test-4.19-race |
|
/test |
|
CI triage:
Previously, the race pipeline jobs would fail constantly, but now are passing which proves that the data race fix is working as intended. |
joestringer
approved these changes
Jan 19, 2023
tommyp1ckles
approved these changes
Jan 19, 2023
| @@ -24,12 +25,13 @@ import ( | |||
| func (k *K8sWatcher) namespacesInit() { | |||
| apiGroup := k8sAPIGroupNamespaceV1Core | |||
|
|
|||
| synced := false | |||
| var synced atomic.Bool | |||
| synced.Store(false) | |||
There was a problem hiding this comment.
this is probably redundant, zero value should be false
There was a problem hiding this comment.
Yeah, I opted for explicitness so that when someone fetches all references of the variable, they see an explicit "false" (next to an explicit "true"). It makes it slightly easier to tell how this variable is used.
|
Marking ready to merge as we have approving reviews and CI passing except for known flakes. |
christarazi
added
the
ready-to-merge
christarazi
removed
needs-backport/1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an atomic variable as the previous boolean was being passed around
to different goroutines without any synchronization mechanism.
Fixes: b4335ee ("k8s: Introduce shared resources")
Fixes: ee2ccda ("k8s: Add shared resource for namespaces")
Fixes: #23166
Signed-off-by: Chris Tarazi chris@isovalent.com