Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable failing encryption connectivity tests on GKE #23183

Merged
merged 1 commit into from Jan 25, 2023
Merged

Disable failing encryption connectivity tests on GKE #23183

merged 1 commit into from Jan 25, 2023

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented Jan 19, 2023 •
edited

Encryption connectivity tests are failing on the new version of GKE clusters.
Disable encryption tests until issue #22808 is fixed.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 19, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 19, 2023
@brlbil brlbil changed the title enable run on pull request Disable failing encryption connectivity tests on GKE Jan 19, 2023
@brlbil brlbil force-pushed the pr/brlbil/ci-disable-encryption-test branch 7 times, most recently from 3e20a52 to cc8ca53 Compare January 24, 2023 14:07
@brlbil
gh/workflow: disable failing encryption connectivity tests
543f748 
Encryption connectivity tests are failing on new version of GKE clusters.
This commit disables encryption tests until the problem is fixed.

Signed-off-by: Birol Bilgin <birol@cilium.io>
@brlbil brlbil force-pushed the pr/brlbil/ci-disable-encryption-test branch from 2c599e8 to 543f748 Compare January 24, 2023 16:07
@brlbil
Copy link
Contributor Author

brlbil commented Jan 24, 2023

I have tried to only disable a minimum amount of tests to make encrypted compliance tests pass.
But it did not work so I disabled the steps altogether.

Passed tests:
https://github.com/cilium/cilium/actions/runs/3997396611/jobs/6858680131
https://github.com/cilium/cilium/actions/runs/3997396594/jobs/6858680297

@brlbil brlbil marked this pull request as ready for review January 24, 2023 16:10
@brlbil brlbil requested review from a team as code owners January 24, 2023 16:10
@brlbil brlbil requested review from aanm and nebril January 24, 2023 16:10
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Jan 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 24, 2023
@aanm aanm requested a review from pchaigno January 24, 2023 19:54
pchaigno
pchaigno requested changes Jan 24, 2023
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not strictly against this but wondering a bit about the tradeoff here: couldn't we have pinned the GKE version instead of removing IPsec+GKE coverage?

@brlbil
Copy link
Contributor Author

brlbil commented Jan 24, 2023

@pchaigno The version pinned before but the pinned GKE version no longer exists so this results in all workflow failing.
This way at least we run the first part of the conformance test. Please see the issue here #23153

pchaigno
pchaigno approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks for the context!

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed release-note/misc This PR makes changes that have no direct user impact. labels Jan 24, 2023
@aanm aanm merged commit 1c205a1 into master Jan 25, 2023
@aanm aanm deleted the pr/brlbil/ci-disable-encryption-test branch January 25, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@pchaigno pchaigno pchaigno approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brlbil @nebril @pchaigno @aanm