node: Use new asynchronous IPCache API for Manager (v2)

[christarazi]

On top of #22086 with additional fixes.

Related: #21142

[christarazi]

Key diff from latest push to resolve #23208 (comment) in pkg/ipcache/metadata.go. The change was accidentally lost due to an incorrect rebase 😕. Failure in the CI for kvstore tests highlighted the issue.

Details

-			log.WithError(err2).WithFields(logrus.Fields{
-				logfields.IPAddr:   prefix,
-				logfields.Identity: entry.identity.ID,
-			}).Error("Failed to replace ipcache entry with new identity after label removal. Traffic may be disrupted.")
+			// It's plausible to pull the same information twice
+			// from different sources, for instance in etcd mode
+			// where node information is propagated both via the
+			// kvstore and via the k8s control plane. If the
+			// upsert was rejected due to source precedence, but the
+			// identity is unchanged, then we can safely ignore the
+			// error message.
+			oldID, ok := previouslyAllocatedIdentities[p]
+			if !(ok && oldID.ID == entry.identity.ID && errors.Is(err2, &ErrOverwrite{
+				ExistingSrc: oldID.Source,
+				NewSrc:      entry.identity.Source,
+			})) {
+				log.WithError(err2).WithFields(logrus.Fields{
+					logfields.IPAddr:   prefix,
+					logfields.Identity: entry.identity.ID,
+				}).Error("Failed to replace ipcache entry with new identity after label removal. Traffic may be disrupted.")
+			}

[christarazi]

For some reason, GH thinks that @cilium/cli review is needed but I can't tell why. 🤔

Edit: And Jenkins just triggered a new run somehow 🤦. The CI was all 🟢 before this...

[michi-covalent]

it's because of pkg/logging/logfields/logfields.go, this file is owned by cli team

[michi-covalent]

reviewed logfields.go. looks innocent 😇

[christarazi]

pkg/logging/logfields/logfields.go

Ok, thanks. I wonder how many of that team's members are even aware of that.

[christarazi]

/test

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathConfig Iptables Skip conntrack for pod traffic

Failure Output

FAIL: Found 1 k8s-app=cilium logs matching list of errors that must be investigated:

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/2353/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

[asauber]

Ok, thanks. I wonder how many of that team's members are even aware of that.

I can say I'm very aware of it because I've reviewed changes to it many times :)

I have a feeling the rest of the team is quite familiar with it as well.

[asauber]

Approving config-related changes

[asauber]

/test