labels, ipcache: Introduce convenience NewFrom() #23218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
christarazi
added
area/daemon
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
christarazi
requested review from
aditighag,
nathanjsweet,
gandro and
joestringer
|
cc @joestringer @gandro, this is related to 46d09ac. |
|
/test Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
joestringer
approved these changes
Jan 20, 2023
This new function is a convenience and safe wrapper for creating a copy of a Labels object from another. This is especially useful going forward with the IPcache rework (cilium#21142), where many call sites are being converted from using raw identities over to labels. Being able to create copies of labels without accidentally copying the reference to the backing slice is crucial to avoid very subtle and hard to find bugs. For example: ``` // Node 1 comes online. node1Labels := labels.LabelRemoteNote // Detect that node1 also has the kube-apiserver deployed on it, so add // its label. node1Labels.MergeLabels(labels.LabelKubeAPIServer) ... // Node 2 comes onlne. node2Labels := labels.LabelRemoteNote // Now node2Labels contains the kube-apiserver label as well because // node1Labels was set to the reference of labels.LabelRemoteNote. ``` Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/labels-newfrom
branch
from
bcdaf19
to
c80bc1d
Compare
|
/test |
nathanjsweet
approved these changes
Jan 23, 2023
aditighag
approved these changes
Jan 23, 2023
|
Runtime test hit: #22373 |
|
/test-runtime |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new function is a convenience and safe wrapper for creating a copy
of a Labels object from another.
This is especially useful going forward with the IPcache rework
(#21142), where many call sites
are being converted from using raw identities over to labels. Being able
to create copies of labels without accidentally copying the reference to
the backing slice is crucial to avoid very subtle and hard to find bugs.
For example:
Signed-off-by: Chris Tarazi chris@isovalent.com