New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Generate SBOM during image release #23221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
and removed
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
labels
Jan 20, 2023
joestringer
added
the
dont-merge/preview-only
Only for preview or testing, don't merge it.
label
Jan 20, 2023
This failed with the image sha not being passed to the signing step: https://github.com/cilium/cilium/actions/runs/3971027337/jobs/6807456125#step:16:19
|
aanm
force-pushed
the
submit/restore-sbom
branch
2 times, most recently
from
January 22, 2023 20:56
a4e0eed
to
4d5c4b3
Compare
This reverts commit b7cd73e. SBOM was a focus of some of the problems around the upgrade to docker buildx v0.10 which introduces various build failures across the Cilium CI. It was reverted to try to get CI back in a stable state. This was unsuccessful because the root cause was not related to these workflow changes, rather these steps add a downstream consumer of the docker images and the docker image format changed. While reverting these steps did prevent them from breaking CI, there were other parts of CI that also still broke due to the image format change. Given that these CI steps were running successfully for the better part of the last week already and they weren't the root cause of the recent CI instability, I think it makes sense to restore this feature into CI. Signed-off-by: Joe Stringer <joe@cilium.io>
aanm
force-pushed
the
submit/restore-sbom
branch
from
January 22, 2023 21:07
4d5c4b3
to
cb8c860
Compare
aanm
approved these changes
Jan 22, 2023
aanm
removed
the
dont-merge/preview-only
Only for preview or testing, don't merge it.
label
Jan 22, 2023
aanm
force-pushed
the
submit/restore-sbom
branch
2 times, most recently
from
January 22, 2023 23:18
1dd4666
to
cb8c860
Compare
Merging since this PR was verified with the test commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b7cd73e.
SBOM was a focus of some of the problems around the upgrade to docker
buildx v0.10 which introduces various build failures across the Cilium
CI. It was reverted to try to get CI back in a stable state. This was
unsuccessful because the root cause was not related to these workflow
changes, rather these steps add a downstream consumer of the docker
images and the docker image format changed. While reverting these steps
did prevent them from breaking CI, there were other parts of CI that
also still broke due to the image format change. Given that these CI
steps were running successfully for the better part of the last week
already and they weren't the root cause of the recent CI instability, I
think it makes sense to restore this feature into CI.
Reverts: #23204