Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: enable gosec G402 (minimum TLS version) #23247

Merged
merged 1 commit into from Jan 24, 2023

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented Jan 23, 2023

Enable gosec, starting with G402 "Look for bad TLS connection settings" only.

@kaworu kaworu added kind/enhancement This would improve or streamline existing functionality. area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Jan 23, 2023
@kaworu kaworu requested review from a team as code owners January 23, 2023 12:51
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 23, 2023
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
@kaworu kaworu force-pushed the pr/kaworu/enable-gosec-G402 branch from f778bcc to 1c13ee5 Compare January 23, 2023 12:54
@kaworu kaworu removed the kind/community-contribution This was a contribution made by a community member. label Jan 23, 2023
Copy link
Contributor

@chancez chancez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More security more better. LGTM.

@kaworu
Copy link
Member Author

kaworu commented Jan 24, 2023

golangci-lint action succeeded, the rest of the patch don't need a full CI run so marking as ready-to-merge.

@kaworu kaworu added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 24, 2023
@ldelossa ldelossa merged commit ca890a4 into cilium:master Jan 24, 2023
@kaworu kaworu deleted the pr/kaworu/enable-gosec-G402 branch January 24, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants