Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: improve metav1 package import statement #23248

Merged
merged 1 commit into from Jan 25, 2023
Merged

Cleanup: improve metav1 package import statement #23248

merged 1 commit into from Jan 25, 2023

Conversation

my-git9
Copy link
Contributor

@my-git9 my-git9 commented Jan 23, 2023

Improve metav1 package import statement

@my-git9 my-git9 requested review from a team as code owners January 23, 2023 13:17
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 23, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 23, 2023
@gandro
Copy link
Member

gandro commented Jan 23, 2023

Thanks for the PR! It seems there are some build failures, could you please address them:

https://github.com/cilium/cilium/actions/runs/3986769699/jobs/6835733649#step:9:134

@my-git9 my-git9 force-pushed the cleanup/metav1 branch 3 times, most recently from 2599471 to 4482eec Compare January 23, 2023 15:20
@gandro gandro added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Jan 23, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 23, 2023
@gandro
Copy link
Member

gandro commented Jan 23, 2023

/test

christarazi
christarazi requested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. In the commit body, can you say "This commit contains no functional changes."?

@my-git9
Copy link
Contributor Author

my-git9 commented Jan 24, 2023 •
edited

Thanks for the PR. In the commit body, can you say "This commit contains no functional changes."?

Updated, thanks.

@christarazi
Copy link
Member

christarazi commented Jan 24, 2023 •
edited

/test

Edit:

@my-git9
Copy link
Contributor Author

my-git9 commented Jan 24, 2023

/test

@christarazi christarazi removed the request for review from tommyp1ckles January 25, 2023 07:14
@christarazi
Copy link
Member

Marking ready to merge as we have approving reviews and CI has passed except for known flakes.

@christarazi christarazi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 25, 2023
@my-git9
improve metav1 package import statement
b3f0836 
This commit contains no functional changes.

Signed-off-by: xin.li <xin.li@daocloud.io>
@ldelossa ldelossa merged commit 4944457 into cilium:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@my-git9 @gandro @christarazi @ldelossa