Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements for Raspberry Pi #23337

Merged
merged 1 commit into from Jan 29, 2023
Merged

Add requirements for Raspberry Pi #23337

merged 1 commit into from Jan 29, 2023

Conversation

darox
Copy link
Contributor

@darox darox commented Jan 25, 2023

Add documentation for running Cilium on a Raspberry Pi.

Signed-off-by: darox 9934402+darox@users.noreply.github.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!
docs: Add requirements for installing Cilium on Raspberry Pi

@darox darox requested review from a team as code owners January 25, 2023 10:34
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 25, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 25, 2023
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jan 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 25, 2023
@qmonnet
Copy link
Member

qmonnet commented Jan 25, 2023

Please, can you also consider using a real email address in the commit's Signed-off-by: tag? Although this doesn't happen often, we've had to reach out to some contributors in the past.

@darox darox requested review from a team as code owners January 25, 2023 13:04
@darox darox requested review from aanm and nebril January 25, 2023 13:05
@darox
Copy link
Contributor Author

darox commented Jan 25, 2023

Please, can you also consider using a real email address in the commit's Signed-off-by: tag? Although this doesn't happen often, we've had to reach out to some contributors in the past.

Done

@aanm aanm requested review from qmonnet and gentoo-root and removed request for a team, nebril, aanm and YutaroHayakawa January 25, 2023 15:58

.. code-block:: shell-session

sudo apt install linux-modules-extra-$(uname -r)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sudo apt install linux-modules-extra-$(uname -r)
sudo apt install linux-modules-extra-raspi

As far as I understand (correct me if I'm wrong), linux-modules-extra-raspi pulls in the latest version of linux-modules-extra-*, updating it automatically with kernel updates. If you just install linux-modules-extra-$(uname -r), Cilium will break again after a kernel update.

(Also I checked Ubuntu for amd64, and it doesn't require linux-modules-extra for xfrm_user and xfrm_interfaces, which were apparently missing here, so the "Ubuntu 22.04 on Raspberry Pi" header looks good to me.)

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me assuming Maxim's comment gets addressed

Add documentation for running Cilium on a Raspberry Pi.

Signed-off-by: darox <maderdario@gmail.com>
Copy link
Contributor

@gentoo-root gentoo-root left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmunteanu
Copy link

@darox your documentation covers only Ubuntu, what about default RaspiOS?

@darox
Copy link
Contributor Author

darox commented Feb 21, 2023

@darox your documentation covers only Ubuntu, what about default RaspiOS?

I expect the default OS to require the same package. However, I don't have one at hand to test it.

@fmunteanu
Copy link

fmunteanu commented Feb 21, 2023

@darox it does not. This is a major roadblock since the kernel developers will not modify it, just to accommodate a third party app, as they describe Cilium in raspberrypi/linux#5354. And they are correct. Right now RaspiOS users need to recompile the kernel, in order to accommodate the Cilium requirements, which is unrealistic for updates. I opened #23640 with Cilium.

@darox
Copy link
Contributor Author

darox commented Feb 21, 2023

I didnt't know that. Thank you for the clarification.

@fmunteanu
Copy link

fmunteanu commented Feb 21, 2023

@darox not sure if you could help bring this to the attention of Cilium devs, it should be an easy fix. Cilium binary should accept default CONFIG_ARM64_VA_BITS_39 value.

@joestringer
Copy link
Member

@fmunteanu Is there some change that you could propose as a PR? It's not clear to me how Cilium interacts with the kernel flag CONFIG_ARM64_VA_BITS_39.

@fmunteanu
Copy link

@joestringer is it possible to continue this discussion into #23640?

@joestringer
Copy link
Member

@fmunteanu ah yes, that would be better than discussing on this PR. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants