test: Unquarantine working FQDN test #23357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit bdb6247 ("test: put pending tests under quarantine"), we quarantined the FQDN test to ensure policy enforcement works after a Cilium restart. The commit doesn't explain why, so it looks like it may have been unintentional. The CI dashboard [1] also shows that the test is working fine, so might have never been flaky. Let's reenable. 1 - https://datastudio.google.com/s/oIZfsw5ZJ_Y Fixes: bdb6247 ("test: put pending tests under quarantine") Signed-off-by: Paul Chaignon <paul@cilium.io>
Since we don't run the ginkgo tests on GKE anymore, this code is dead. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
kind/bug/CI
pchaigno
changed the title
|
/test-vagrant |
nebril
approved these changes
Jan 26, 2023
|
The LB changes are just removing dead code so I think we can skip that review. Maciej review and tests are passing so marking ready to merge. |
pchaigno
added
the
ready-to-merge
christarazi
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit unquarantines an FQDN test that appears to have been quarantined by mistake (?). The second commit removes some dead code. See commits for details.