New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(bpf): update unprivileged_bpf_disabled description #23378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That's a useful precision.
I've got a few observations:
- Could you please improve the title of your second commit (or alternatively, squash them)?
- I see the SUSE ticket, but better link references for the commit description would be instead:
- Please find some additional feedback inline below.
Thanks! Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good, thank you!
(Please next time squash the commits when it makes no sense to keep the second separate - I did it this time.)
Thanks! I will do it the next time. BTW, we can use GitHub's "Squash and merge" button on the PR page to squash the commits automatically before merging. The Redefine GitHub extension has the ability to remove the intermediate commit message when squashing via web UI: https://github.com/refined-github/refined-github#editing-pull-requests. I recommend these because they have saved me lots of time when I maintain open source projects. 😃 |
See: git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=08389d888287c3823f80b0216766b71e17f0aba5 kernel.org/doc/html/v6.1/admin-guide/sysctl/kernel.html?highlight=unprivileged_bpf_disabled#unprivileged-bpf-disabled [ Quentin: squashed second commit (table right-side extension). ] Signed-off-by: spacewander <spacewanderlzx@gmail.com> Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Just sync the master branch into this PR... |
We have it disabled on Cilium. Although the feature could be useful at times, we prefer 1) avoiding the risk of squashing by accident when we do need to keep distinct commits to understand the changes, 2) avoiding the risks of confusion for users who are not so familiar with Git and that would see their branch modified under them, 3) avoiding to put the burden of choosing between rebase or squash for the person who merges (as a consequence, the responsibility to split/squash appropriately usually falls down to the commit author).
No it's fine, as long as there's no conflict you can ignore this warning. |
Checkpatch and documentation workflow have passed. Travis error is #23314. This PR is only related to docs, and the reviews are in, so we're good to go. |
See https://www.suse.com/support/kb/doc/?id=000020545
Signed-off-by: spacewander spacewanderlzx@gmail.com
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.