Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf/test: Get rid of 4.9 leftovers #23399

Merged
merged 1 commit into from Feb 2, 2023
Merged

bpf/test: Get rid of 4.9 leftovers #23399

merged 1 commit into from Feb 2, 2023

Conversation

brb
Copy link
Member

@brb brb commented Jan 27, 2023 •
edited

Misc cleanup which is part of [1].

[1]: #22116

NOTE: merge it only if we agree on #23381 (comment)

@brb brb added kind/cleanup This includes no functional changes. release-note/ci This PR makes changes to the CI. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jan 27, 2023
@brb
Copy link
Member Author

brb commented Jan 30, 2023

/test

@brb brb marked this pull request as ready for review January 30, 2023 15:36
@brb brb requested review from a team as code owners January 30, 2023 15:36
@brb brb requested review from ti-mo, nebril and aspsk January 30, 2023 15:36
pchaigno
pchaigno reviewed Feb 1, 2023
View reviewed changes
bpf/Makefile Outdated Show resolved Hide resolved
@brb
bpf/test: Get rid of 4.9 leftovers
6322212 
Misc cleanup which is part of [1].

[1]: #22116

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb requested a review from pchaigno February 2, 2023 13:26
@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 2, 2023
@pchaigno pchaigno merged commit 4095784 into master Feb 2, 2023
@pchaigno pchaigno deleted the pr/brb/misc-cleanup-49 branch February 2, 2023 15:19
@ti-mo
Copy link
Contributor

ti-mo commented Feb 3, 2023

The tip of the iceberg. 😅 Backports necessary, though?

@brb
Copy link
Member Author

brb commented Feb 3, 2023

Backports necessary, though?

Nice to have, but not critical.

@pchaigno pchaigno mentioned this pull request Feb 12, 2023
Merged
29 tasks
@pchaigno pchaigno added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Feb 12, 2023
@julianwiedmann julianwiedmann mentioned this pull request Feb 13, 2023
Closed
@aanm aanm added backport/author The backport will be carried out by the author of the PR. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Feb 13, 2023
@julianwiedmann
Copy link
Member

Backports necessary, though?

Nice to have, but not critical.

Let's drop the 1.13 backport label, we're past the "nice to have" stage :).

@julianwiedmann julianwiedmann removed the needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@pchaigno pchaigno pchaigno approved these changes

@ti-mo ti-mo Awaiting requested review from ti-mo ti-mo was automatically assigned from cilium/loader

@aspsk aspsk Awaiting requested review from aspsk aspsk was automatically assigned from cilium/sig-datapath

Assignees
No one assigned
Labels
backport/author The backport will be carried out by the author of the PR. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@brb @ti-mo @julianwiedmann @nebril @pchaigno @aanm