hubble-relay: deprecate peer svc through local unix domain socket #23407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaworu
added
kind/cleanup
kaworu
force-pushed
the
pr/kaworu/relay/deprecate-peer-svc-through-local-unix-domain-socket
branch
from
cade90c
to
1bea450
Compare
rolinh
added
the
needs-backport/1.13
kaworu
force-pushed
the
pr/kaworu/relay/deprecate-peer-svc-through-local-unix-domain-socket
branch
from
1bea450
to
8a2f4d2
Compare
kaworu
removed
the
needs-backport/1.13
rolinh
approved these changes
Jan 30, 2023
kaworu
force-pushed
the
pr/kaworu/relay/deprecate-peer-svc-through-local-unix-domain-socket
branch
from
8a2f4d2
to
cbc6f60
Compare
|
Travis-CI hit #23314 |
michi-covalent
approved these changes
Jan 30, 2023
qmonnet
approved these changes
Jan 30, 2023
aanm
approved these changes
Jan 31, 2023
Hubble server has been integrated into the Cilium agent since v1.9, released Nov 10th 2020. Some doc fixes and improvements on the way. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
Since Cilium v1.12 Hubble Relay has been connecting to the Hubble Peer service through the hubble-peer Kubernetes Service (i.e. TCP) by default. The ability to query the Peer Service through the local UNIX domain socket for Relay has been kept for compatibility reasons and as a fallback solution, but we should move away from sharing socket through Pods as it has potential security implications. This patch deprecate disabling the hubble-peer Kubernetes Service as it will be the only option once the local UNIX domain support for the Peer Service in Hubble Relay is removed. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
force-pushed
the
pr/kaworu/relay/deprecate-peer-svc-through-local-unix-domain-socket
branch
from
cbc6f60
to
7af198e
Compare
kaworu
added
the
area/documentation
|
Doc change only, no need for a full CI run so marking this one as |
kaworu
added
the
ready-to-merge
kaworu
deleted the
pr/kaworu/relay/deprecate-peer-svc-through-local-unix-domain-socket
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here, requested by @aanm.