Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tooling: remove depedency on GOPATH for k8s api generation #23428

Merged
merged 1 commit into from Jan 31, 2023
Merged

tooling: remove depedency on GOPATH for k8s api generation #23428

merged 1 commit into from Jan 31, 2023

Conversation

ldelossa
Copy link
Contributor

this commit removes the hard-coded pathing required for make generate-k8s-api.

it is now possible to generate k8s API inside a git worktree.

the only requirement is that go list -m returns Cilium's module name when ran in the root, or any child of it, directory.

Signed-off-by: Louis DeLosSantos louis.delos@isovalent.com

Remove dependency on $GOPATH for `make generate-k8s-api`

@ldelossa ldelossa requested a review from a team as a code owner January 28, 2023 01:37
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 28, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 28, 2023
@ldelossa ldelossa added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jan 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 28, 2023
@ldelossa ldelossa added release-note/misc This PR makes changes that have no direct user impact. and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Jan 28, 2023
@aanm aanm removed the kind/community-contribution This was a contribution made by a community member. label Jan 29, 2023
@ldelossa
tooling: remove depedency on GOPATH for k8s api generation
6defcae 
this commit removes the hard-coded pathing required for `make
generate-k8s-api`.

it is now possible to generate k8s API inside a git worktree.

the only requirement is that `go list -m` returns Cilium's module name
when ran in the root, or any child of it, directory.

Signed-off-by: Louis DeLosSantos <louis.delos@isovalent.com>
@ldelossa ldelossa requested a review from aanm January 30, 2023 16:59
@ldelossa
Copy link
Contributor Author

/test

@ldelossa
Copy link
Contributor Author

/test-runtime

@aanm aanm merged commit f49bdc0 into cilium:master Jan 31, 2023
@ldelossa ldelossa deleted the cilium-no-gopath branch February 1, 2023 14:55
@christarazi christarazi added area/build Anything to do with the build, more general then area/CI backport/author The backport will be carried out by the author of the PR. affects/v1.13 This issue affects v1.13 branch labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@borkmann borkmann Awaiting requested review from borkmann borkmann was automatically assigned from cilium/build

Assignees
No one assigned
Labels
affects/v1.13 This issue affects v1.13 branch area/build Anything to do with the build, more general then area/CI backport/author The backport will be carried out by the author of the PR. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldelossa @aanm @christarazi