Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.gitattributes: Highlight Jenkinsfiles as Groovy #23435

Merged
merged 1 commit into from Jan 31, 2023
Merged

.gitattributes: Highlight Jenkinsfiles as Groovy #23435

merged 1 commit into from Jan 31, 2023

Conversation

pchaigno
Copy link
Member

See https://github.com/github/linguist/blob/master/docs/overrides.md for the documentation of those overrides.

@pchaigno
.gitattributes: Highlight Jenkinsfile as Groovy
8ced657 
See [1] for the documentation of those overrides.

1 - https://github.com/github/linguist/blob/master/docs/overrides.md
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools. labels Jan 29, 2023
@pchaigno pchaigno requested a review from a team as a code owner January 29, 2023 14:03
qmonnet
qmonnet approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know they were based on Groovy, but web search results seem to agree. Looks good to me.

@qmonnet qmonnet merged commit f92321b into cilium:master Jan 31, 2023
@pchaigno
Copy link
Member Author

Didn't know they were based on Groovy, but web search results seem to agree. Looks good to me.

It's also what Linguist uses to highlight Jenkinsfile files: https://github.com/github/linguist/blob/c1c34e5260797b4d598f5ec76f19723bfc5a1894/lib/linguist/languages.yml#L2503.

@pchaigno pchaigno deleted the syntax-highlight-jenkinsfiles branch January 31, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pchaigno @qmonnet