Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: additional coverage #23494

Merged
merged 2 commits into from Feb 1, 2023
Merged

CODEOWNERS: additional coverage #23494

merged 2 commits into from Feb 1, 2023

Conversation

tklauser
Copy link
Member

The first commit adds CODEOWNERS coverage for some additional, non-trivial code directories. The second commit narrows the scope of servicemesh-specific packages in the operator.

Assign some previously unassigned, non-trivial code directories and
files to the respective teams.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools. labels Jan 31, 2023
@tklauser tklauser requested a review from a team as a code owner January 31, 2023 14:18
These packages contain code specific to the servicemesh functionality
and don't require operator-specific review.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser removed the request for review from aditighag February 1, 2023 09:46
@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 1, 2023
@qmonnet qmonnet merged commit 47b6ebf into master Feb 1, 2023
@qmonnet qmonnet deleted the pr/tklauser/codeowners-misc branch February 1, 2023 10:26
@qmonnet
Copy link
Member

qmonnet commented Feb 1, 2023

I filed #23509 for the failed Travis build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants