New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvstore: Propagate ClusterID with Service #23514
Merged
pchaigno
merged 1 commit into
cilium:master
from
YutaroHayakawa:yutaro/oss/clustermesh-overlapping-podcidr/service-kv
Feb 21, 2023
Merged
kvstore: Propagate ClusterID with Service #23514
pchaigno
merged 1 commit into
cilium:master
from
YutaroHayakawa:yutaro/oss/clustermesh-overlapping-podcidr/service-kv
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Feb 1, 2023
YutaroHayakawa
added
area/clustermesh
Relates to multi-cluster routing functionality in Cilium.
release-note/misc
This PR makes changes that have no direct user impact.
labels
Feb 1, 2023
YutaroHayakawa
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Feb 2, 2023
nebril
approved these changes
Feb 2, 2023
Member
Author
jrajahalme
approved these changes
Feb 14, 2023
This is a part of the Cluster Mesh with overlapping PodCIDR support. Remote cluster puts ClusterID information to the service. So that the cluster with cluster-aware addressing enabled can annotate service backend IP with ClusterID. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
force-pushed
the
yutaro/oss/clustermesh-overlapping-podcidr/service-kv
branch
from
February 20, 2023 08:46
c4ee18b
to
69a7c10
Compare
Fixed conflict with the latest master. |
/test |
I think failure in the ConformanceGKE is a variant of #22368. |
/ci-gke |
There's no datapath change, so it doesn't make sense to run complexity tests. Let me make this ready to merge. |
YutaroHayakawa
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/clustermesh
Relates to multi-cluster routing functionality in Cilium.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of Cluster Mesh with overlapping PodCIDR support. Please see the commit message for more details. This includes the kvstore data format change (added a new field), but shouldn't make any compatibility issue since no one using that yet.