Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvstore: Propagate ClusterID with Service #23514

Conversation

YutaroHayakawa
Copy link
Member

This is a part of Cluster Mesh with overlapping PodCIDR support. Please see the commit message for more details. This includes the kvstore data format change (added a new field), but shouldn't make any compatibility issue since no one using that yet.

kvstore: Propagate ClusterID with Service

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 1, 2023
@YutaroHayakawa YutaroHayakawa added area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/misc This PR makes changes that have no direct user impact. labels Feb 1, 2023
@YutaroHayakawa YutaroHayakawa marked this pull request as ready for review February 1, 2023 15:56
@YutaroHayakawa YutaroHayakawa requested review from a team as code owners February 1, 2023 15:56
@YutaroHayakawa YutaroHayakawa removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 2, 2023
@YutaroHayakawa
Copy link
Member Author

YutaroHayakawa commented Feb 3, 2023

/test

Job 'Cilium-PR-K8s-1.16-kernel-4.9' has 4 failures but they might be new flakes since it also hit 1 known flakes: #22056 (91.34)

Job 'Cilium-PR-K8s-1.26-kernel-net-next' has 2 failures but they might be new flakes since it also hit 1 known flakes: #22056 (93.54)

This is a part of the Cluster Mesh with overlapping PodCIDR support.
Remote cluster puts ClusterID information to the service. So that the
cluster with cluster-aware addressing enabled can annotate service
backend IP with ClusterID.

Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
@YutaroHayakawa YutaroHayakawa force-pushed the yutaro/oss/clustermesh-overlapping-podcidr/service-kv branch from c4ee18b to 69a7c10 Compare February 20, 2023 08:46
@YutaroHayakawa
Copy link
Member Author

YutaroHayakawa commented Feb 20, 2023

Fixed conflict with the latest master.

@YutaroHayakawa
Copy link
Member Author

/test

@YutaroHayakawa
Copy link
Member Author

YutaroHayakawa commented Feb 21, 2023

I think failure in the ConformanceGKE is a variant of #22368.

@YutaroHayakawa
Copy link
Member Author

/ci-gke

@YutaroHayakawa
Copy link
Member Author

There's no datapath change, so it doesn't make sense to run complexity tests. Let me make this ready to merge.

@YutaroHayakawa YutaroHayakawa added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 21, 2023
@pchaigno pchaigno merged commit 3b05104 into cilium:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants