Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensure cleanup in hubble "test L7 flow" #23525

Merged
merged 1 commit into from Feb 8, 2023

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Feb 2, 2023

Move the deferral of the annotation removal before its addition, to ensure it is removed if the post-addition check fails. This prevents cascading failures.

Signed-off-by: Marco Iorio marco.iorio@isovalent.com

Fixes: #issue-number

test: ensure cleanup in hubble "test L7 flow"

Move the deferral of the annotation removal before its addition, to
ensure it is removed if the post-addition check fails. This prevents
cascading failures.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added the release-note/misc This PR makes changes that have no direct user impact. label Feb 2, 2023
@giorio94 giorio94 requested review from a team as code owners February 2, 2023 07:56
@giorio94
Copy link
Member Author

giorio94 commented Feb 2, 2023

/test

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. sig/hubble Impacts hubble server or relay and removed release-note/misc This PR makes changes that have no direct user impact. labels Feb 2, 2023
@pchaigno pchaigno merged commit 705afce into cilium:master Feb 8, 2023
@giorio94 giorio94 deleted the mio/hubble-test branch February 8, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. sig/hubble Impacts hubble server or relay
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants