k8s: use core/v1 consts for topology-aware hints annotation/label #23538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to duplicate these in Cilium's k8s package, they are defined in k8s.io/api/core/v1 already, see: https://github.com/cilium/cilium/blob/b8786b36e93daf3c779216b6f23327ff19f8cc66/vendor/k8s.io/api/core/v1/annotation_key_constants.go#L147-L150 https://github.com/cilium/cilium/blob/b8786b36e93daf3c779216b6f23327ff19f8cc66/vendor/k8s.io/api/core/v1/well_known_labels.go#L22 Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
kind/cleanup
|
/test |
|
/test-runtime hit #22373 https://jenkins.cilium.io/job/Cilium-PR-Runtime-net-next/4864/ |
tommyp1ckles
approved these changes
Feb 21, 2023
tklauser
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to duplicate these in Cilium's
k8spackage, they are defined ink8s.io/api/core/v1already, see:cilium/vendor/k8s.io/api/core/v1/annotation_key_constants.go
Lines 147 to 150 in b8786b3
cilium/vendor/k8s.io/api/core/v1/well_known_labels.go
Line 22 in b8786b3