contrib: Set IPv6 for dual-stack Kubenetes nodeIP on dev VM #23543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
jschwinger233
force-pushed
the
gray/fix-node-ipv6
branch
from
efe5afd
to
f60ecd8
Compare
pchaigno
added
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pchaigno
reviewed
Feb 2, 2023
jschwinger233
force-pushed
the
gray/fix-node-ipv6
branch
3 times, most recently
from
056493f
to
7b12d3f
Compare
pchaigno
approved these changes
Feb 9, 2023
aditighag
reviewed
Feb 10, 2023
There was a problem hiding this comment.
Please fix the checkpatch warning -
Error: ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'zc greyschwinger@gmail.com'
I'll lean on Paul's review here as I haven't had to use IPv6 setup recently.
jschwinger233
force-pushed
the
gray/fix-node-ipv6
branch
2 times, most recently
from
adb1ee0
to
68e2537
Compare
The development setup using the provided Vagrantfile will give a dual-stack Kubernetes cluster in the dev VM, but a hostNetwork pod deployed on it cannot show an IPv6 address. This is because the kubelet is deployed using the incomplete `--node-ip` parameter: to enable dual-stack mode, we must pass both IPv6 address and IPv4 address via `--node-ip` to kubelet. This commit completes the `--node-ip` parameter and fixes the issue. Fixes: cilium#23503 Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
jschwinger233
force-pushed
the
gray/fix-node-ipv6
branch
from
68e2537
to
651a582
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The development setup using the provided Vagrantfile will give a dual-stack Kubernetes cluster in the dev VM, but a hostNetwork pod deployed on it cannot show an IPv6 address.
This is because the kubelet is deployed using the incomplete
--node-ipparameter: to enable dual-stack mode, we must pass both IPv6 address and IPv4 address via--node-ipto kubelet.This PR completes the
--node-ipparameter and fixes the issue.Signed-off-by: Zhichuan Liang gray.liang@isovalent.com
Fixes: #23503