ipcache: Fix wrong assertion in ipcache metadata test #23549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christarazi
added
area/proxy
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
christarazi
removed
the
area/proxy
By code inspection, I realized that labels.LabelKubeAPIServer was not the right key to use, but rather labels.IDNameKubeAPIServer. The test still passed because it was asserting if the label was NOT in the label set, which it wasn't, but not for the right reasons. Fix the assertion in case of regressions in the future. Fixes: f1b30c1 ("ipcache: Generate new identity if label is removed") Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/fix-unit-test-ipcache-md
branch
from
96d151f
to
a2b1c52
Compare
jrajahalme
approved these changes
Feb 14, 2023
|
This PR is fixing unit test code so only Travis is needed for signal. Marking ready to merge as we have approving reviews. |
christarazi
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By code inspection, I realized that labels.LabelKubeAPIServer was not
the right key to use, but rather labels.IDNameKubeAPIServer. The test
still passed because it was asserting if the label was NOT in the label
set, which it wasn't, but not for the right reasons.
Fix the assertion in case of regressions in the future.
Fixes: f1b30c1 ("ipcache: Generate new identity if label is removed")
Signed-off-by: Chris Tarazi chris@isovalent.com