Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cilium/cmd: Remove deprecated policy_trace command #23550

Merged
merged 1 commit into from Feb 27, 2023
Merged

cilium/cmd: Remove deprecated policy_trace command #23550

merged 1 commit into from Feb 27, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Feb 3, 2023

Signed-off-by: Tam Mach tam.mach@cilium.io

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 3, 2023
@sayboras sayboras added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Feb 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 3, 2023
@sayboras sayboras added kind/cleanup This includes no functional changes. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Feb 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 3, 2023
@sayboras sayboras marked this pull request as ready for review February 11, 2023 13:26
@sayboras sayboras requested a review from a team as a code owner February 11, 2023 13:26
@sayboras sayboras requested a review from a team as a code owner February 15, 2023 12:24
@sayboras sayboras marked this pull request as draft February 15, 2023 12:35
@sayboras
cilium/cmd: Remove deprecated policy_trace command
3ae5cc9 
Remove /policy/resolve from swagger and re-generate related file
again.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras marked this pull request as ready for review February 16, 2023 13:06
@sayboras sayboras requested review from a team as code owners February 16, 2023 13:06
@sayboras
Copy link
Member Author

/test

gandro
gandro approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I believe there there is potentially even more code to be removed, i.e. some of the code here:

cilium/pkg/policy/policy.go

Lines 17 to 28 in 5feb34e

type Tracing int
const (
TRACE_DISABLED Tracing = iota
TRACE_ENABLED
TRACE_VERBOSE
)
// TraceEnabled returns true if the SearchContext requests tracing.
func (s *SearchContext) TraceEnabled() bool {
return s.Trace != TRACE_DISABLED
}

But it might be easier to remove that in a separate PR

ldelossa
ldelossa approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sayboras
Copy link
Member Author

/test-runtime

@sayboras
Copy link
Member Author

/test-1.16-4.19

@sayboras
Copy link
Member Author

test-runtime hits #23297

@sayboras
Copy link
Member Author

sayboras commented Feb 18, 2023 •
edited

/test-1.16-4.19

Re-run due to environment issue

@sayboras
Copy link
Member Author

test-1.16-4.19 hits #23845

@sayboras
Copy link
Member Author

test-1.16-4.19 hits #23845 :(

https://jenkins.cilium.io/job/Cilium-PR-K8s-1.16-kernel-4.19/56/testReport/junit/Suite-k8s-1/16/K8sUpdates_Tests_upgrade_and_downgrade_from_a_Cilium_stable_image_to_master/

DNS entry is not ready after timeout
Expected
    <*errors.errorString | 0xc002282480>: {
        s: "DNS 'app1-service.default.svc.cluster.local' is not ready after timeout: 7m0s timeout expired",
    }
to be nil
/home/jenkins/workspace/Cilium-PR-K8s-1.16-kernel-4.19/src/github.com/cilium/cilium/test/k8s/updates.go:374

@sayboras
Copy link
Member Author

Required code owner reviews are in, CI are all passed. Marking this ready to merge.

@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 27, 2023
@sayboras sayboras merged commit 0ce84af into cilium:master Feb 27, 2023
@sayboras sayboras deleted the tam/remove-policy-trace branch February 27, 2023 11:18
@margamanterola margamanterola mentioned this pull request Dec 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@ldelossa ldelossa ldelossa approved these changes

@aditighag aditighag aditighag approved these changes

@nathanjsweet nathanjsweet Awaiting requested review from nathanjsweet nathanjsweet was automatically assigned from cilium/api

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sayboras @gandro @ldelossa @aditighag