Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: Remove unneeded orig_sip from ipv6_host_policy_ingress #23577

Merged
merged 1 commit into from Feb 5, 2023

Conversation

gentoo-root
Copy link
Contributor

There is no need to copy the IPv6 address to a local variable, because the packet data is not going to change. Just use the address from the packet headers directly.

Signed-off-by: Maxim Mikityanskiy maxim@isovalent.com

There is no need to copy the IPv6 address to a local variable, because
the packet data is not going to change. Just use the address from the
packet headers directly.

Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
@gentoo-root gentoo-root requested a review from a team as a code owner February 4, 2023 15:41
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 4, 2023
@gentoo-root gentoo-root added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Feb 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 4, 2023
@pchaigno pchaigno added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Feb 4, 2023
@pchaigno
Copy link
Member

pchaigno commented Feb 4, 2023

Changing release-note label to misc as we don't expect any user-visible change. Please answer if I'm wrong.

@pchaigno
Copy link
Member

pchaigno commented Feb 4, 2023

The host firewall isn't currently covered outside of Vagrant tests.
/test-vagrant

@maintainer-s-little-helper
Copy link

Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed:

Click to show.

Test Name

K8sDatapathConfig Host firewall With VXLAN

Failure Output

FAIL: Failed to reach 10.0.0.154:80 from testclient-host-bhqr9

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.24-kernel-5.4 so I can create one.

@pchaigno
Copy link
Member

pchaigno commented Feb 5, 2023

IntegrationTests failed with known flake #23314. k8s-1.24-kernel-5.4 failed with known flake #15455. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants