Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo for k8s-install #23585

Merged
merged 1 commit into from Feb 6, 2023
Merged

fix typo for k8s-install #23585

merged 1 commit into from Feb 6, 2023

Conversation

yanggangtony
Copy link
Contributor

@yanggangtony yanggangtony commented Feb 6, 2023 •
edited by qmonnet

Signed-off-by: yanggang gang.yang@daocloud.io

docs: Fix a typo in K8s with Kubespray installation guide

fix typo for k8s-install
2918ca2 
Signed-off-by: yanggang <gang.yang@daocloud.io>
@yanggangtony yanggangtony requested a review from a team as a code owner February 6, 2023 03:26
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 6, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Feb 6, 2023
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Feb 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 6, 2023
@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 6, 2023
@pchaigno pchaigno merged commit 81fe462 into cilium:master Feb 6, 2023
@pchaigno
Copy link
Member

pchaigno commented Feb 6, 2023

@yanggangtony Please batch your PRs. These kind of very small PRs are a bit noisy. And please tell your colleagues.

@yanggangtony
Copy link
Contributor Author

@pchaigno
😄😄
thanks for review.
next time will batch the doc's pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yanggangtony @pchaigno @qmonnet