New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renovate: add support for GH workflow updates #23625
Conversation
08cbe09
to
356269d
Compare
I also struggled with this. Doing a bit of searching, it seems that renovate supports JSON5. Should we add our config as JSON5 so we can document the file a bit better? The Hubble digest logic also could use some comments renovatebot/renovate#3555 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renovate config looks good to me. As mentioned above, we should explore storing it as json5 to support comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not checking that comments match SHA, but config LGTM.
356269d
to
ff7bf90
Compare
Dependabot is causing to much noise by opening multiple PRs in the repository. Thus, we will be moving the dependency update of GH actions to renovate. With renovate we are able to group all GH actions updates within a single PR on every friday. As we can't comment on JSON files, the reason why 'google/oss-fuzz' is ignored from the updates is because it's currently unversioned so it would be receiving an update every time the upstream repository would receive a new commit. These changes were tested in the following PR aanm#461 The related documentation can be found in https://docs.renovatebot.com/modules/manager/github-actions/ Signed-off-by: André Martins <andre@cilium.io>
ff7bf90
to
eb3e601
Compare
Related to #23625 This comment will allow renovate to automatically update GH actions dependencies. Signed-off-by: André Martins <andre@cilium.io>
Related to #23625 This comment will allow renovate to automatically update GH actions dependencies. Signed-off-by: André Martins <andre@cilium.io>
Related to #23625 This comment will allow renovate to automatically update GH actions dependencies. Signed-off-by: André Martins <andre@cilium.io>
Related to #23625 This comment will allow renovate to automatically update GH actions dependencies. Signed-off-by: André Martins <andre@cilium.io>
Related to #23625 This comment will allow renovate to automatically update GH actions dependencies. Signed-off-by: André Martins <andre@cilium.io>
Related to #23625 This comment will allow renovate to automatically update GH actions dependencies. Signed-off-by: André Martins <andre@cilium.io>
Related to #23625 This comment will allow renovate to automatically update GH actions dependencies. Signed-off-by: André Martins <andre@cilium.io>
Related to #23625 This comment will allow renovate to automatically update GH actions dependencies. Signed-off-by: André Martins <andre@cilium.io>
Dependabot is causing to much noise by opening multiple PRs in the repository. Thus, we will be moving the dependency update of GH actions to renovate.
With renovate we are able to group all GH actions updates within a single PR on every friday.
As we can't comment on JSON files, the reason why 'google/oss-fuzz' is ignored from the updates is because it's currently unversioned so it would be receiving an update every time the upstream repository would receive a new commit.
These changes were tested in the following PR aanm#461
The related documentation can be found in https://docs.renovatebot.com/modules/manager/github-actions/
Signed-off-by: André Martins andre@cilium.io
Note for TH These PRs should be merged first:
#23621
#23622
#23623
#23624