Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: add support for GH workflow updates #23625

Merged
merged 1 commit into from Feb 10, 2023
Merged

renovate: add support for GH workflow updates #23625

merged 1 commit into from Feb 10, 2023

Conversation

aanm
Copy link
Member

@aanm aanm commented Feb 7, 2023

Dependabot is causing to much noise by opening multiple PRs in the repository. Thus, we will be moving the dependency update of GH actions to renovate.

With renovate we are able to group all GH actions updates within a single PR on every friday.

As we can't comment on JSON files, the reason why 'google/oss-fuzz' is ignored from the updates is because it's currently unversioned so it would be receiving an update every time the upstream repository would receive a new commit.

These changes were tested in the following PR aanm#461

The related documentation can be found in https://docs.renovatebot.com/modules/manager/github-actions/

Signed-off-by: André Martins andre@cilium.io

Note for TH These PRs should be merged first:
#23621
#23622
#23623
#23624

@aanm aanm added dont-merge/waiting-for-upstream Only merge once upstream library or kernel features have landed release-note/misc This PR makes changes that have no direct user impact. labels Feb 7, 2023
@aanm aanm requested review from a team as code owners February 7, 2023 23:31
@gandro
Copy link
Member

gandro commented Feb 8, 2023

As we can't comment on JSON files, the reason why 'google/oss-fuzz' is ignored from the updates is because it's currently unversioned so it would be receiving an update every time the upstream repository would receive a new commit.

I also struggled with this. Doing a bit of searching, it seems that renovate supports JSON5. Should we add our config as JSON5 so we can document the file a bit better? The Hubble digest logic also could use some comments renovatebot/renovate#3555

Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renovate config looks good to me. As mentioned above, we should explore storing it as json5 to support comments.

@tklauser tklauser added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Feb 10, 2023
Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not checking that comments match SHA, but config LGTM.

Dependabot is causing to much noise by opening multiple PRs in the
repository. Thus, we will be moving the dependency update of GH actions
to renovate.

With renovate we are able to group all GH actions updates within a
single PR on every friday.

As we can't comment on JSON files, the reason why 'google/oss-fuzz' is
ignored from the updates is because it's currently unversioned so it
would be receiving an update every time the upstream repository would
receive a new commit.

These changes were tested in the following PR aanm#461

The related documentation can be found in https://docs.renovatebot.com/modules/manager/github-actions/

Signed-off-by: André Martins <andre@cilium.io>
aanm added a commit that referenced this pull request Feb 10, 2023
Related to #23625

This comment will allow renovate to automatically update GH actions
dependencies.

Signed-off-by: André Martins <andre@cilium.io>
aanm added a commit that referenced this pull request Feb 10, 2023
Related to #23625

This comment will allow renovate to automatically update GH actions
dependencies.

Signed-off-by: André Martins <andre@cilium.io>
aanm added a commit that referenced this pull request Feb 10, 2023
Related to #23625

This comment will allow renovate to automatically update GH actions
dependencies.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm removed the dont-merge/waiting-for-upstream Only merge once upstream library or kernel features have landed label Feb 10, 2023
aanm added a commit that referenced this pull request Feb 10, 2023
Related to #23625

This comment will allow renovate to automatically update GH actions
dependencies.

Signed-off-by: André Martins <andre@cilium.io>
aanm added a commit that referenced this pull request Feb 10, 2023
Related to #23625

This comment will allow renovate to automatically update GH actions
dependencies.

Signed-off-by: André Martins <andre@cilium.io>
aanm added a commit that referenced this pull request Feb 10, 2023
Related to #23625

This comment will allow renovate to automatically update GH actions
dependencies.

Signed-off-by: André Martins <andre@cilium.io>
aanm added a commit that referenced this pull request Feb 10, 2023
Related to #23625

This comment will allow renovate to automatically update GH actions
dependencies.

Signed-off-by: André Martins <andre@cilium.io>
aanm added a commit that referenced this pull request Feb 10, 2023
Related to #23625

This comment will allow renovate to automatically update GH actions
dependencies.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Feb 10, 2023
@aanm aanm merged commit 169f0f2 into master Feb 10, 2023
@aanm aanm deleted the pr/renovate-test branch February 10, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants