alibabacloud: use DescribeVSwitches to get vswitch tags #23635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
|
Hello @l1b0k please help to review, thank you |
christarazi
approved these changes
Feb 9, 2023
christarazi
added
release-note/misc
haozhangami
force-pushed
the
use-describevswitches-to-get-vswitch-tags
branch
2 times, most recently
from
233a7b3
to
fb01593
Compare
|
/test |
Obtaining the vswitch tags through ListTagResources is incomplete, which will cause the IP allocation to fail and require additional queries. Therefore, use DescribeVSwitches to get the vswitch tags. Signed-off-by: Hao Zhang <hao.zhang.am.i@gmail.com>
haozhangami
force-pushed
the
use-describevswitches-to-get-vswitch-tags
branch
from
fb01593
to
a57ba66
Compare
|
/test |
1 similar comment
|
/test |
|
👋 Just a note that only cilium team member can trigger tests via /test comment. I have re-triggered the tests, please avoid force push till the tests are done. Thanks a lot for your contribution. |
|
All CI jobs are passed (except ci-verifier is in waiting for status stage, but this job is not required as part of the changes here), reviews are in, marking this ready to merge. |
sayboras
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obtaining the vswitch tags through ListTagResources is incomplete, which will cause the IP allocation to fail and require additional queries. Therefore, use DescribeVSwitches to get the vswitch tags.
Signed-off-by: Hao Zhang hao.zhang.am.i@gmail.com