Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Flag --ipv4-native-routing-cidr update in cli #23643

Merged
merged 1 commit into from Mar 7, 2023
Merged

fix: Flag --ipv4-native-routing-cidr update in cli #23643

merged 1 commit into from Mar 7, 2023

Conversation

deepeshaburse
Copy link
Contributor

Signed-off-by: Deepesha Burse deepesha.3007@gmail.com

Please ensure your pull request adheres to the following guidelines:

  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Thanks for contributing!

Fixes: #23144

@deepeshaburse deepeshaburse requested review from a team as code owners February 9, 2023 07:26
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 9, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Feb 9, 2023
qmonnet
qmonnet approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, following cilium/cilium-cli@17f9630. Thanks!

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/cli Impacts the command line interface of any command in the repository. release-note/misc This PR makes changes that have no direct user impact. labels Feb 10, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 10, 2023
@qmonnet
Copy link
Member

qmonnet commented Feb 10, 2023

However, I would recommend providing the motivation for the change (ideally with the related reference to the deprecation) in the commit description.

@deepeshaburse
Copy link
Contributor Author

@qmonnet sure, I'll reword the commit. Thanks!

@maintainer-s-little-helper
Copy link

Commit 6f0ef49f32c96dd4374842201d144c0d1a64686b does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Feb 13, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Feb 13, 2023
@deepeshaburse
fix: Deprecated flag --ipv4-native-routing-cidr update in cli
3c1c942 
Signed-off-by: Deepesha Burse <deepesha.3007@gmail.com>
@aanm aanm added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 6, 2023
@YutaroHayakawa YutaroHayakawa merged commit f296f1e into cilium:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/cli Impacts the command line interface of any command in the repository. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Docs: Flag --ipv4-native-routing-cidr has been deprecated in cli tool
5 participants
@deepeshaburse @qmonnet @aanm @jrajahalme @YutaroHayakawa