Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/kind: default to dual-stack clusters #23646

Merged
merged 1 commit into from Feb 15, 2023
Merged

contrib/kind: default to dual-stack clusters #23646

merged 1 commit into from Feb 15, 2023

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Feb 9, 2023 •
edited

It takes a small magical incantation to enable dual-stack. Let's just enable dual-stack for development environments by default.

@squeed
contrib/kind: default to dual-stack clusters
383c815 
It takes a small magical incantation to enable dual-stack. Let's just
enable dual-stack for development enviroments by default.

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
@squeed squeed requested a review from a team as a code owner February 9, 2023 13:19
@squeed squeed requested a review from aditighag February 9, 2023 13:19
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 9, 2023
@squeed squeed added the release-note/misc This PR makes changes that have no direct user impact. label Feb 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 9, 2023
@squeed
Copy link
Contributor Author

squeed commented Feb 9, 2023

fyi @borkmann

@squeed
Copy link
Contributor Author

squeed commented Feb 15, 2023

There's no need for a full CI run; contrib/scripts/kind.sh is not used by any CI jobs.

Manually marking this as ready-to-merge.

@squeed squeed added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 15, 2023
@pchaigno pchaigno merged commit d53d0be into cilium:master Feb 15, 2023
@pchaigno pchaigno added the sig/contributing Impacts contribution workflow, guidelines, and tools. label Feb 15, 2023
@tklauser tklauser added the needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch label Mar 28, 2023
@tklauser tklauser mentioned this pull request Mar 28, 2023
Merged
9 tasks
@tklauser tklauser added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 28, 2023
@tklauser tklauser added this to Backport pending to v1.13 in 1.13.2 Mar 28, 2023
@tklauser tklauser removed the backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. label Mar 30, 2023
@tklauser tklauser removed this from Backport pending to v1.13 in 1.13.2 Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditighag aditighag aditighag approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@squeed @aditighag @tklauser @pchaigno