Fix docker-cilium-image target for DOCKER_FLAGS=--push #23679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the docker-cilium-image Makefile target with DOCKER_FLAGS set to `--push` and DOCKER_IMAGE_SUFFIX defined, each step of the build that reference the image name should take into account the specified suffix. Instead, the build fails while trying to fetch and inspect the manifest: ``` $ DOCKER_DEV_ACCOUNT=docker.io/pippolo84 DOCKER_IMAGE_SUFFIX=-ci DOCKER_IMAGE_TAG=makefiletest DOCKER_FLAGS=--push make docker-cilium-image ... docker buildx imagetools inspect docker.io/pippolo84/cilium:makefiletest ERROR: docker.io/pippolo84/cilium:makefiletest: not found make: *** [Makefile.docker:124: docker-cilium-image] Error 1 ``` The error message highlights that the suffix is not added when generating the fully qualified image name in the manifest inspection command. The commit adds the missing $(DOCKER_IMAGE_SUFFIX) variable to fix the issue. Fixes: 3fd3691 ("build: Makefile support for DOCKER_IMAGE_SUFFIX, CI_BUILD, and KIND_LOAD") Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
pippolo84
added
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
nebril
approved these changes
Feb 13, 2023
jrajahalme
approved these changes
Feb 16, 2023
jrajahalme
added
the
ready-to-merge
|
Marked as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the docker-cilium-image Makefile target with DOCKER_FLAGS set to
--pushand DOCKER_IMAGE_SUFFIX defined, each step of the build that reference the image name should take into account the specified suffix.Instead, the build fails while trying to fetch and inspect the manifest:
The error message highlights that the suffix is not added when generating the fully qualified image name in the manifest inspection command.
The commit adds the missing $(DOCKER_IMAGE_SUFFIX) variable to fix the issue.
Fixes: 3fd3691 ("build: Makefile support for DOCKER_IMAGE_SUFFIX, CI_BUILD, and KIND_LOAD")